-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clash-verge-rev: Fix shotcuts name and uninstall script #14494
Conversation
All changes look good. Wait for review from human collaborators. clash-verge-rev
|
/verify |
All changes look good. Wait for review from human collaborators. clash-verge-rev
|
Oops, my bad. I forget to send this comment. Thank you! |
Author has removed portable version since v2.x, so the config path is |
I agree with you. But I am somewhat busy currently, would you like to modify it to polish the file? Migration config would be hard, I guess. The author recommends that to install v2.x, uninstall v1.x version fully first. So there must be something incompatible. Currently, the old config files are stored in In addition, one of clash-verge-rev's collaborators released a portable version with the aim to support scoop (see here clash-verge-rev/clash-verge-rev#2240 (comment), it is not under official org though), should we change the download link back again? My opinion is not, since there is no need to use portable now, and downloading from the official repo is more reliable. |
But the author still retains the detection of the "PORTABLE" flag. Please refer to the file "clash-verge-rev/src-tauri/src/utils/dirs.rs", the original approach of using "$persist_dir\.config" is still valid. |
Let's open a new issue if there are more details to be discussed. The topic has changed now and is not suits for this place. |
The shortcuts name was wrong. Also, the services must be uninstalled, or it will prevent to remove related files.
Relates to #14460 (comment)
Closes #14495
Closes #14500