Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clash-verge-rev: Fix shotcuts name and uninstall script #14494

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

mslxl
Copy link
Contributor

@mslxl mslxl commented Dec 2, 2024

The shortcuts name was wrong. Also, the services must be uninstalled, or it will prevent to remove related files.

Relates to #14460 (comment)
Closes #14495
Closes #14500

Copy link
Contributor

github-actions bot commented Dec 2, 2024

All changes look good.

Wait for review from human collaborators.

clash-verge-rev

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@aliesbelik
Copy link
Collaborator

/verify

Copy link
Contributor

github-actions bot commented Dec 4, 2024

All changes look good.

Wait for review from human collaborators.

clash-verge-rev

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@aliesbelik aliesbelik merged commit 6f7c77c into ScoopInstaller:master Dec 4, 2024
3 checks passed
@mslxl
Copy link
Contributor Author

mslxl commented Dec 4, 2024

Oops, my bad. I forget to send this comment.

Thank you!

@H-Tung
Copy link
Contributor

H-Tung commented Dec 4, 2024

Author has removed portable version since v2.x, so the config path is C:\Users\YOU\AppData\Roaming\io.github.clash-verge-rev.clash-verge-rev now without any config, while old portable-version users have their config in %SCOOP%\persist\clash-verge-rev\.config\io.github.clash-verge-rev.clash-verge-rev.
Should we still make a symbollink to get the config files under scoop dirctory?

@mslxl
Copy link
Contributor Author

mslxl commented Dec 5, 2024

Author has removed portable version since v2.x, so the config path is C:\Users\YOU\AppData\Roaming\io.github.clash-verge-rev.clash-verge-rev now without any config, while old portable-version users have their config in %SCOOP%\persist\clash-verge-rev\.config\io.github.clash-verge-rev.clash-verge-rev. Should we still make a symbollink to get the config files under scoop dirctory?

I agree with you.

But I am somewhat busy currently, would you like to modify it to polish the file?

Migration config would be hard, I guess. The author recommends that to install v2.x, uninstall v1.x version fully first. So there must be something incompatible. Currently, the old config files are stored in persist dir, so it would be a BREAK CHANGE by making a symbol link to get the config files under scoop directory without any other operation. But we can tell the old user to run scoop uninstall clash-verge-rev -p first, just leave the problem to users

In addition, one of clash-verge-rev's collaborators released a portable version with the aim to support scoop (see here clash-verge-rev/clash-verge-rev#2240 (comment), it is not under official org though), should we change the download link back again? My opinion is not, since there is no need to use portable now, and downloading from the official repo is more reliable.

@xyalter
Copy link
Contributor

xyalter commented Dec 6, 2024

Author has removed portable version since v2.x, so the config path is C:\Users\YOU\AppData\Roaming\io.github.clash-verge-rev.clash-verge-rev now without any config, while old portable-version users have their config in %SCOOP%\persist\clash-verge-rev\.config\io.github.clash-verge-rev.clash-verge-rev. Should we still make a symbollink to get the config files under scoop dirctory?

But the author still retains the detection of the "PORTABLE" flag. Please refer to the file "clash-verge-rev/src-tauri/src/utils/dirs.rs", the original approach of using "$persist_dir\.config" is still valid.

@mslxl
Copy link
Contributor Author

mslxl commented Dec 6, 2024

Let's open a new issue if there are more details to be discussed. The topic has changed now and is not suits for this place.

@mslxl mslxl mentioned this pull request Dec 10, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants